feat(ratelimit): Adding principal metrics #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robzienert
force-pushed
the
ratelimit-principal-metrics
branch
from
8ca0c56 to
3a425ea
Compare
|
"I think you're fine." @jrsquared |
robzienert
force-pushed
the
ratelimit-principal-metrics
branch
from
3a425ea to
8aa583e
Compare
|
If they don't complain, then we're fine. |
danielpeach
pushed a commit
to danielpeach/gate
that referenced
this pull request
May 24, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like this should be fine as far as costs go, despite the high dimensionality.
@spinnaker/netflix-reviewers PTAL